Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace _build_simple_adam with _build_stateful_sgd. #302

Merged
merged 2 commits into from Feb 8, 2022
Merged

Replace _build_simple_adam with _build_stateful_sgd. #302

merged 2 commits into from Feb 8, 2022

Conversation

n2cholas
Copy link
Contributor

@n2cholas n2cholas commented Feb 7, 2022

Replace the incorrect _build_simple_adam helper with _build_stateful_sgd, as discussed on #300.

cc: @mkunesch

@mkunesch mkunesch self-requested a review February 8, 2022 11:48
mkunesch
mkunesch requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@mkunesch mkunesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thanks a lot! Only have two small nits on naming/wording other than that LGTM!

optax/_src/wrappers_test.py Outdated Show resolved Hide resolved
optax/_src/wrappers_test.py Outdated Show resolved Hide resolved
@mkunesch mkunesch self-assigned this Feb 8, 2022
mkunesch
mkunesch approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@mkunesch mkunesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks a lot! Will merge asap so that you can use it in the other PR.

@copybara-service copybara-service bot merged commit 28f9627 into google-deepmind:master Feb 8, 2022
@n2cholas n2cholas deleted the stateful_sgd_test branch February 8, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkunesch mkunesch mkunesch approved these changes

Assignees

@mkunesch mkunesch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n2cholas @mkunesch