Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start inject_hyperparams step count at 0. #416

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

Start inject_hyperparams step count at 0.

This fixes issue #415. Previously, inject_hyperparams started with
step_count=1 in the first update when using schedules (it incremented before
passing it to the schedule) whereas scale_by_schedule started with
step_count=0. To make this consistent, this PR changes inject_hyperparams
to also start at 0, i.e. increment the count only after passing it to the
schedule.

The PR comes with a test that breaks without the change. Furthermore, the step
counts in the existing tests of inject_hyperparams had to be decremented by
one in order for the tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants