Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose adamax and adamaxw #433

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

nasyxx
Copy link
Contributor

@nasyxx nasyxx commented Oct 4, 2022

Issue #429

@google-cla
Copy link

google-cla bot commented Oct 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hbq1
Copy link
Collaborator

hbq1 commented Oct 4, 2022

Thanks! Could you also add these symbols to the Sphinx docs?

@nasyxx
Copy link
Contributor Author

nasyxx commented Oct 4, 2022

Could you also add these symbols to the Sphinx

Done! Please let me know if there is anything else that needs to be changed.

@copybara-service copybara-service bot merged commit e026a15 into google-deepmind:master Oct 5, 2022
@nasyxx nasyxx deleted the patch-1 branch October 5, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants