Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary %pip install statements from the notebooks #762

Conversation

JayJayleee
Copy link
Contributor

This PR removes unnecessary %pip install statements from adversarial_training.ipynb and cifar10_resnet.ipynb from examples.

Addressing issue #756

@fabianp
Copy link
Member

fabianp commented Feb 3, 2024

Thanks @JayJayleee ! This looks good to me.

Congrats on your first contribution to optax 🎉 🚀 !

@JayJayleee
Copy link
Contributor Author

JayJayleee commented Feb 4, 2024

Thanks @JayJayleee ! This looks good to me.

Congrats on your first contribution to optax 🎉 🚀 !

Thank you fabianp! :)

@fabianp
Copy link
Member

fabianp commented Feb 4, 2024

We're now just waiting for someone else from Google to approve the changes. Should be done by tomorrow or so

@fabianp fabianp requested review from fabianp and removed request for fabianp February 4, 2024 17:20
@copybara-service copybara-service bot merged commit c86b9a9 into google-deepmind:main Feb 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants