Clarify formula for cosine learning rate. #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_609994404
branch
2 times, most recently
from
7c41ebd
to
90762e8
Compare
I think it's useful to have the precise formula of the learning in the docstring. Otherwise I find myself often going to the source code to understand the learning rate. PiperOrigin-RevId: 610120777
copybara-service
bot
force-pushed
the
test_609994404
branch
from
90762e8
to
7aa5e79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify formula for cosine learning rate.
I think it's useful to have the precise
formula of the learning in the docstring.
Otherwise I find myself often going to the
source code to understand the learning rate.