Updating Dockerfile (pip install) #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lespeholt
reviewed
Jan 10, 2019
|
I think this could be tested, I added and the bazel version because i was having this issue #16 (comment) |
Draichi
commented
Jan 10, 2019
|
Seems like both of those issues have been fixed. |
|
Happy to accept a change to use dm-sonnet==1.23 |
…all dependencies'" This reverts commit 6119845.
|
Ok brother, updated on 44626b4 |
|
Thanks for fixing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to update Dockerfile. The latest version of sonnet is in conflict with something.
I was able to run the project by adding the
dm-sonnetstable version and includingtensorflow_probabilityto the list.Related issues: