Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook magics to work with Gemini #109

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

markmcd
Copy link
Member

@markmcd markmcd commented Dec 13, 2023

Adds some aliases for the commands too:

  • %%palm still works, for backwards compat
  • %%llm as a generic magic
  • %%gemini as an analogue to %%palm

Motivation

Need to work with the new API and new models.

Type of change

Choose one: New feature

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@markmcd markmcd requested a review from a team as a code owner December 13, 2023 06:03
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Dec 13, 2023
@MarkDaoust
Copy link
Collaborator

MarkDaoust commented Dec 18, 2023

I broke the presubmit tests for this. Have you run the tests manually?

@MarkDaoust
Copy link
Collaborator

MarkDaoust commented Dec 19, 2023

We should probably merge #141 first.

@markmcd
Copy link
Member Author

markmcd commented Dec 20, 2023

Yeah I have run them manually but will rebase properly & ensure they pass in CI first.

@MarkDaoust MarkDaoust added this to the 0.3.3 milestone Dec 21, 2023
Adds some aliases for the commands too:
 * `%%palm` still works, for backwards compat
 * `%%llm` as a generic magic
 * `%%gemini` as an analogue to `%%palm`
@MarkDaoust
Copy link
Collaborator

Rebased onto main.

@MarkDaoust MarkDaoust merged commit 7abbdf3 into google-gemini:main Jan 11, 2024
6 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants