Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic tools support. #120

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add basic tools support. #120

merged 1 commit into from
Dec 18, 2023

Conversation

MarkDaoust
Copy link
Collaborator

No description provided.

@MarkDaoust MarkDaoust requested a review from a team as a code owner December 14, 2023 22:36
@MarkDaoust MarkDaoust marked this pull request as draft December 14, 2023 22:36
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Dec 14, 2023
@MarkDaoust MarkDaoust mentioned this pull request Dec 15, 2023
Merged
@MarkDaoust MarkDaoust marked this pull request as ready for review December 15, 2023 18:24
@MarkDaoust
Copy link
Collaborator Author

Also tested in Colab with pip install git+https://github.com/markdaoust/generative-ai-python@tools

markmcd
markmcd approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still says draft but you mentioned merging it so LGTM.

(edit: doesn't say draft after I refresh 🤦 )

@markmcd markmcd merged commit b97aa55 into google-gemini:main Dec 18, 2023
8 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 18, 2023
@MarkDaoust
Copy link
Collaborator Author

Yes. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarkDaoust @markmcd