Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiter, anext not exist error #127

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

Andy963
Copy link
Contributor

@Andy963 Andy963 commented Dec 15, 2023

Description of the change

solve aiter, anext not exit in pthon 3.9 ,but maybe there is a better way?

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)
bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@Andy963 Andy963 requested a review from a team as a code owner December 15, 2023 15:09
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Dec 15, 2023
@Andy963
Copy link
Contributor Author

Andy963 commented Dec 16, 2023

@MarkDaoust after more test, I found that even with the implementation of aiter and anext, there could still be some other issues, especially in stream mode.
AttributeError: '_WrappedUnaryStreamCall' object has no attribute '__next__'

@MarkDaoust
Copy link
Collaborator

Hi, thanks for reporting back.

Was that with your version of this code?

Can you give me some code snippet to reproduce this?

@MarkDaoust
Copy link
Collaborator

SHouldn't the test I enabled in my commit have this case covered?

@MarkDaoust
Copy link
Collaborator

I'd like to merge this and roll a new release today.

I'll do some tests on this soon.

@Andy963
Copy link
Contributor Author

Andy963 commented Dec 18, 2023

Hi, thanks for reporting back.

Was that with your version of this code?

Can you give me some code snippet to reproduce this?

yes, Your new implemention works fine for me

@MarkDaoust MarkDaoust merged commit 8f05227 into google-gemini:main Dec 19, 2023
6 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants