Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Semantic Retriever. #230

Merged
merged 75 commits into from
Mar 28, 2024
Merged

Finish Semantic Retriever. #230

merged 75 commits into from
Mar 28, 2024

Conversation

shilpakancharla
Copy link
Collaborator

Description of the change

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

shilpakancharla and others added 21 commits February 5, 2024 16:22
@shilpakancharla
Make naming corpus and document also optional.
7961ba9
@shilpakancharla
Update logic to naming conditions
180f906
@shilpakancharla
reformat
ccb9b26
@shilpakancharla
Update to add document_name variable
73e6ec4
@shilpakancharla
Update to add corpus_name variable
b9fa79c
@shilpakancharla
Updated CustomMetadata
920e5d2
@shilpakancharla
Updated CustomMetadata notation
1536077
@shilpakancharla
Updating time fields on chunk object
a85cc6b
@shilpakancharla
Testing time fields on chunk
c93794b
@shilpakancharla
Try making times optional params
6709e29
@shilpakancharla
none otpion to time
396ea89
@shilpakancharla
Updated batch create chunks, updated time format for list corpora
245b3ba
@shilpakancharla
Reformat
35ce0aa
@shilpakancharla
Can accept full name or partial name in get and delete methods
ceb6016
@shilpakancharla
Updated functionality of update methods
1fa867b
@shilpakancharla
Added tests for additional changes
b9ae81f
@shilpakancharla
Merge branch 'google:main' into match_docs
098b514
@shilpakancharla
Add custom metadata handling for document
0a5f466
@MarkDaoust
These should be ints.
ea433c8
@shilpakancharla
Adding in semantic retriever config as paramter, add generate_answer_…
1ab040e 
…async
@shilpakancharla
Merge branch 'match_docs' of https://github.com/shilpakancharla/gener…
95862b9 
…ative-ai-python into match_docs
@shilpakancharla shilpakancharla requested a review from a team as a code owner March 7, 2024 20:45
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Mar 7, 2024
MarkDaoust
MarkDaoust requested changes Mar 8, 2024
View reviewed changes
google/generativeai/answer.py Outdated Show resolved Hide resolved
google/generativeai/answer.py Outdated Show resolved Hide resolved
google/generativeai/answer.py Outdated Show resolved Hide resolved
google/generativeai/answer.py Outdated Show resolved Hide resolved
google/generativeai/answer.py Outdated Show resolved Hide resolved
shilpakancharla and others added 17 commits March 12, 2024 13:53
@MarkDaoust MarkDaoust changed the title Match docs Finish Semantic Retriever. Mar 25, 2024
@MarkDaoust
Copy link
Collaborator

In the future, we should break things into smaller PRs.

@MarkDaoust MarkDaoust merged commit 6b281da into google-gemini:main Mar 28, 2024
7 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Mar 28, 2024
@MarkDaoust MarkDaoust mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shilpakancharla @MarkDaoust