Sdk update to use glm 0.6.1 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proto def for glm.GenerateContentRequest lists system_instruction as singular
github-actions
bot
added
status:awaiting review
markmcd
previously approved these changes
Apr 3, 2024
There was a problem hiding this comment.
This looks unrelated to the PR. Accidental?
If it's intentional - please try to keep PRs focused (go/small-cls or the public copy). It helps if we ever need to roll back changes if things are easily separable.
There was a problem hiding this comment.
function_calling_mode was supposed to be a follow-on PR, pushed on the same branch by mistake. Should I revert ?
There was a problem hiding this comment.
Yeah if you can - push it ASAP & we can merge this.
There was a problem hiding this comment.
Done. Should be good to go.
markmcd
approved these changes
Apr 3, 2024
github-actions
bot
removed
the
status:awaiting review
MarkDaoust
reviewed
Apr 8, 2024
| @@ -42,7 +42,7 @@ def get_version(): | |||
| release_status = "Development Status :: 5 - Production/Stable" | |||
|
|
|||
| dependencies = [ | |||
| "google-ai-generativelanguage@https://storage.googleapis.com/generativeai-downloads/preview/ai-generativelanguage-v1beta-py.tar.gz", | |||
| "google-ai-generativelanguage==0.6.1", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glmpackage to use0.6.1.GenerateContentRequestlistssystem_instructionin singular as the field is not repeated. This is consistent with the latest release(glm==0.6.1)TypedDictfromtyping_extensionsChecklist
git pull --rebase upstream main).