Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function calling mode patch #271

Merged
merged 10 commits into from
Apr 5, 2024
Merged

Function calling mode patch #271

merged 10 commits into from
Apr 5, 2024

Conversation

mayureshagashe2105
Copy link
Contributor

Handle appropriate conversion for function_calling_mode when passed as a FunctionCallingConfigDict TyedDict.

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@mayureshagashe2105 mayureshagashe2105 requested a review from a team as a code owner April 3, 2024 09:20
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Apr 3, 2024
markmcd
markmcd requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests please

shilpakancharla
shilpakancharla previously approved these changes Apr 3, 2024
View reviewed changes
markmcd
markmcd previously approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmcd markmcd merged commit 7d2c17e into google-gemini:main Apr 5, 2024
7 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

@shilpakancharla shilpakancharla shilpakancharla left review comments

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mayureshagashe2105 @markmcd @shilpakancharla