Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request options to chat. #341

Merged
merged 7 commits into from
May 22, 2024

Conversation

MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented May 14, 2024

Needs tests.

Fixes: #335

Change-Id: I6f7e4c980fd7e2a14fec4c3e2d837ad745c69c9a
@MarkDaoust MarkDaoust marked this pull request as draft May 14, 2024 18:54
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels May 14, 2024
@aidoskanapyanov
Copy link
Contributor

Hi, @MarkDaoust ! It seems like missed a couple of methods in my original #204 PR 😅
Do need a hand w/ adding unit tests for these?

Change-Id: Ia224e9e8327443a9920ce5d9a877ebb8c272e583
Change-Id: I7eed70131346c7d7ffe435c8f6909f7eb3f7e9f7
Change-Id: I0d32ba2057893e5d3e46ef850135aa479cdf3729
Change-Id: I4b92a5bc25aa7bf11bfaf31aa6c029096f3e68bc
@MarkDaoust MarkDaoust marked this pull request as ready for review May 20, 2024 22:07
@MarkDaoust
Copy link
Collaborator Author

Hey @aidoskanapyanov, thanks again for the help!

I think this one is a simple fix.

@MarkDaoust MarkDaoust marked this pull request as draft May 20, 2024 22:09
Change-Id: I368315f220413ba9508012721e64093372555590
Change-Id: I26c7fa1f040e7d1ea16068034d78fb9f6cc13db0
@MarkDaoust MarkDaoust marked this pull request as ready for review May 21, 2024 13:38
@markmcd markmcd merged commit 0dca4ce into google-gemini:main May 22, 2024
8 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add client timeout setting to overcome timeout errors.
3 participants