Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public Codable (Decodable and/or Encodable) conformance #142

Merged
merged 1 commit into from Apr 19, 2024

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented Apr 19, 2024

Removed public Codable (Decodable and/or Encodable) conformance. This is primarily a documentation change, e.g., Citation has init(from: any Decoder) throws listed as an initializer in the 0.4.1 docs but it has been removed as of #135 (docs for main -- listed as a Default Implementation only). This change is being proposed to discourage the use of these initializers.

Note: In case the links don't load, Swift Package Index's documentation server appears to be flaky at the moment.

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Apr 19, 2024
@andrewheard andrewheard merged commit 584b1e9 into main Apr 19, 2024
9 checks passed
@andrewheard andrewheard deleted the ah/remove-public-codable branch April 19, 2024 21:04
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants