Re-order the GenerativeModel convenience constructors in source
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:swift sdk
github-actions
bot
removed
the
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the
GenerativeModelconvenience constructor accepting asystemInstruction: ModelContent? = nilabove the one acceptingsystemInstruction: String...inGenerativeModel.swift. Xcode's autocomplete seems to order them based on the order they appear in the source file. Previously the first constructor listed appeared to requiresystemInstruction, which might mislead devs into thinking it is required.Before:
After:
Note: This is not a breaking change, only cosmetic,
systemInstruction: nilhas always been supported since being introduced in the https://github.com/google-gemini/generative-ai-swift/releases/tag/0.4.11.