Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up exported credentials when the workflow finishes #67

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Clean up exported credentials when the workflow finishes #67

merged 2 commits into from
Dec 1, 2021

Conversation

sethvargo
Copy link
Member

@sethvargo sethvargo requested a review from a team as a code owner November 30, 2021 18:35
@google-cla google-cla bot added the cla: yes label Nov 30, 2021
@sethvargo sethvargo force-pushed the sethvargo/cleanup branch 2 times, most recently from 73d4a3a to 505f161 Compare November 30, 2021 18:36
@sethvargo sethvargo enabled auto-merge (squash) November 30, 2021 18:36
@sethvargo
Copy link
Member Author

This diff is large because it's creating a new compiled .js file, but the actual typescript diff is pretty small and easy to review.

bharathkkb
bharathkkb reviewed Nov 30, 2021
View reviewed changes
src/post.ts Outdated Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
@sethvargo
Copy link
Member Author

Hmm - so it actually looks like the credentials file is removed automatically

@sethvargo sethvargo closed this Nov 30, 2021
auto-merge was automatically disabled November 30, 2021 19:47

Pull request was closed

@sethvargo sethvargo deleted the sethvargo/cleanup branch November 30, 2021 19:47
@sethvargo
Copy link
Member Author

auth uses RUNNER_TEMP, so it's automatically cleaned up. setup-gcloud uses GITHUB_WORKSPACE which is why its not being cleaned up.

@sethvargo sethvargo restored the sethvargo/cleanup branch December 1, 2021 16:20
@sethvargo sethvargo reopened this Dec 1, 2021
@sethvargo sethvargo force-pushed the sethvargo/cleanup branch 2 times, most recently from 06742dc to ced9b54 Compare December 1, 2021 16:26
@sethvargo sethvargo enabled auto-merge (squash) December 1, 2021 17:11
@sethvargo sethvargo merged commit 1e9245c into main Dec 1, 2021
@sethvargo sethvargo deleted the sethvargo/cleanup branch December 1, 2021 17:38
@sethvargo sethvargo mentioned this pull request Dec 3, 2021
Merged
@chingor13 chingor13 mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sethvargo @bharathkkb