Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[README.md] Text for flags on deploy-appengine makes reference to cloud run instead of app engine #296

Closed
Rodrigo-JM opened this issue Jan 4, 2023 · 0 comments · Fixed by #297
Closed

[README.md] Text for flags on deploy-appengine makes reference to cloud run instead of app engine #296

Rodrigo-JM opened this issue Jan 4, 2023 · 0 comments · Fixed by #297
Labels
bug Something isn't working

Comments

@Rodrigo-JM
Copy link

TL;DR

THIS PART:

flags: (Optional) Space-separated list of other Cloud Run flags. This can be used to access features that are not exposed via
this GitHub Action.

with:

  flags: '--add-cloudsql-instances=...'

Shouldn't it be referencing app engine?

Expected behavior

No response

Observed behavior

No response

Action YAML

s

Log output

No response

Additional information

No response
@Rodrigo-JM Rodrigo-JM added the bug Something isn't working label Jan 4, 2023
@Rodrigo-JM Rodrigo-JM changed the title Text for flags on deploy-appengine makes reference to cloud run instead of app engine [README.md] Text for flags on deploy-appengine makes reference to cloud run instead of app engine Jan 4, 2023
@sethvargo sethvargo mentioned this issue Jan 4, 2023
Merged
sethvargo added a commit that referenced this issue Jan 4, 2023
@sethvargo
Fix README references to Cloud Run (#297)
02f7eed 
Fixes
#296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix README references to Cloud Run google-github-actions/deploy-appengine
1 participant
@Rodrigo-JM