docs: replace old parameter on example code #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sethvargo
approved these changes
Jan 16, 2024
Merged
sethvargo
pushed a commit
that referenced
this pull request
Jan 23, 2024
## What's Changed * Update README and CI to use latest version by @sethvargo in #342 * docs: replace old parameter on example code by @nasustim in #346 * Stream output when debug is enabled by @sethvargo in #348 * Update deps by @sethvargo in #350 ## New Contributors * @nasustim made their first contribution in #346 **Full Changelog**: v2.0.0...81b21e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers, thank you for the awesome project.
I think that
outputs.urlseems to be deprecated parameter because it's not included in README.md1 now and it returns same value ofoutputs.version_url2.so I replaced
outputs.urltooutputs.version_urlon example code on README.mdFootnotes
https://github.com/google-github-actions/deploy-appengine/blob/abf67aa4ea465aee02104003e9f377d8ec976ade/README.md#outputs ↩
https://github.com/google-github-actions/deploy-appengine/blob/abf67aa4ea465aee02104003e9f377d8ec976ade/src/main.ts#L248-L253 ↩