feat: fail the GitHub Action run if the Cloud Function is not ACTIVE #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations in which the polling operation will complete, but the Cloud Function status is "UNKNOWN" or other values. This usually happens when the deploy succeeds, but the instance immediately dies on boot. In these cases, users need to go look at Cloud Logging to inspect why the deployment succeeded but the instance booting failed.
By checking if the status is ACTIVE, we can ensure that the GitHub Action only "succeeds" if the function fully deploys.
Fixes #71