Skip to content

Commit

Permalink
Update deps to Node 20 (#472)
Browse files Browse the repository at this point in the history
  • Loading branch information
sethvargo committed Nov 8, 2023
1 parent 638bac3 commit 1525f60
Show file tree
Hide file tree
Showing 10 changed files with 495 additions and 457 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cleanup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: 'ubuntu-latest'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'google-github-actions/auth@main'
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ jobs:
name: 'from_${{ matrix.name }}'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- name: 'Compute service name'
run: |-
echo "SERVICE_NAME=${GITHUB_JOB}-${{ matrix.name }}-${GITHUB_SHA::7}-${GITHUB_RUN_NUMBER}" >> ${GITHUB_ENV}
- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- run: 'npm ci && npm run build'

Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
runs-on: 'ubuntu-latest'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- name: 'Compute service name'
run: |-
Expand All @@ -118,9 +118,9 @@ jobs:
run: |-
sed -i "s/run-full-yaml/${{ env.SERVICE_NAME }}/" ./tests/unit/service.yaml
- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- run: 'npm ci && npm run build'

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ jobs:
runs-on: '${{ matrix.os }}'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ support](https://cloud.google.com/support).**
the secrets being requested. See [Authorization](#authorization) for more
information.

- This action runs using Node 16. If you are using self-hosted GitHub Actions
runners, you must use runner version
[2.285.0](https://github.com/actions/virtual-environments) or newer.
- This action runs using Node 20. If you are using self-hosted GitHub Actions
runners, you must use a [runner
version](https://github.com/actions/virtual-environments) that supports this
version or newer.


## Usage
Expand All @@ -33,7 +34,7 @@ jobs:
id-token: 'write'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'google-github-actions/auth@v1'
with:
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -176,5 +176,5 @@ branding:
color: 'blue'

runs:
using: 'node16'
using: 'node20'
main: 'dist/main/index.js'
6 changes: 5 additions & 1 deletion dist/main/index.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions example-app/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# Use the official lightweight Node.js 16 image.
# Use the official lightweight Node.js 20 image.
# https://hub.docker.com/_/node
FROM node:16-slim
FROM node:20-slim

# Create and change to the app directory.
WORKDIR /usr/src/app
Expand Down
Loading

0 comments on commit 1525f60

Please sign in to comment.