Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot deploy if an environment variable contains a whitespace #452

Closed
Thieund opened this issue Jul 3, 2023 · 0 comments · Fixed by #482
Closed

Cannot deploy if an environment variable contains a whitespace #452

Thieund opened this issue Jul 3, 2023 · 0 comments · Fixed by #482
Labels
bug Something isn't working

Comments

@Thieund
Copy link

Thieund commented Jul 3, 2023

TL;DR

If an environment variable contains a space, the value of --update-env-vars is split into 2 separate parts, and the latter is considered as a new command parameter.

Expected behavior

Can update env vars with spaces

Observed behavior

No response

Action YAML

- id: 'deploy'
        uses: 'google-github-actions/deploy-cloudrun@v1.0.2'
        with:
          service: 'xxx-dev'
          image: 'xxx'
          env_vars_file: .env

Log output

No response

Additional information

No response
@Thieund Thieund added the bug Something isn't working label Jul 3, 2023
@sethvargo sethvargo mentioned this issue Jan 22, 2024
Merged
sethvargo added a commit that referenced this issue Jan 22, 2024
@sethvargo
Update deps (#482)
cba191b 
Fixes #469

Fixes
#452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update deps google-github-actions/deploy-cloudrun
1 participant
@Thieund