Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update service polling #31

Merged
merged 14 commits into from
Feb 11, 2021
Merged

fix: Update service polling #31

merged 14 commits into from
Feb 11, 2021

Conversation

averikitsch
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Feb 2, 2021
@averikitsch averikitsch force-pushed the update-polling branch 3 times, most recently from 9cbfae4 to 0c75729 Compare February 2, 2021 20:28
@averikitsch
Copy link
Contributor Author

@bharathkkb this PR and PR #30 are reliant on each other; however I felt it was easier for separate reviews.

src/cloudRun.ts Outdated Show resolved Hide resolved
src/cloudRun.ts Show resolved Hide resolved
@averikitsch
Copy link
Contributor Author

@bharathkkb can you re-review when you have time?

Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review, got buried in emails :)

@Rahma-AlWadhahi
Copy link

Hello @averikitsch, @unrealcloud and @bharathkkb.

@bharathkkb this PR and PR #30 are reliant on each other; however I felt it was easier for separate reviews.

I have noticed that one of the two PRs was merged (#30) while the other is not yet merged (#31). I am facing the same issue which was mentioned in #36 . Could you please take a look at it?

@averikitsch averikitsch merged commit 75b3108 into main Feb 11, 2021
@averikitsch averikitsch deleted the update-polling branch February 11, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants