feat: Add code #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averikitsch
force-pushed
the
initial
branch
5 times, most recently
from
f051843
to
7781e8d
Compare
|
I'm not sure why component installation works when this library is embedded in an action versus these tests. Example averikitsch/deploy-cloudrun#16 |
|
@averikitsch I tried these locally and beta seemed to pass for me. For gsutil I had to bump the gcloud version, maybe an issue with json parsing in that specific version? |
|
Code is ready for review. I will do another review of the documentation and workflows, then plan for publishing to NPM. |
bharathkkb
approved these changes
Jul 30, 2021
| @@ -0,0 +1,66 @@ | |||
| @google-github-actions/setup-cloud-sdk / [Exports](modules.md) | |||
|
|
|||
| # [Google GitHub actions: Setup Cloud SDK Client](https://github.com/google-github-actions) | |||
There was a problem hiding this comment.
This looks the same as the root readme?
There was a problem hiding this comment.
I am generating docs and it copies the README into the docs directory
|
|
||
| ## Table of contents | ||
|
|
||
| ### Functions |
There was a problem hiding this comment.
I am generating this using typedoc (npm run docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will follow up on automating NPM publishing