-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove dist, add release-please #190
Conversation
If we remove dist/ before we run release-please this will break the actions |
@averikitsch so my understanding is that when we merge this to main because of https://github.com/GoogleCloudPlatform/github-actions/blob/e829c1b7b9c2f632d89189668ec8348f5270bfc3/.github/workflows/release-please.yml#L5 this should be triggered and will proceed to recreate those dists and commit to main, so yes technically we will be broken on main for a couple of minutes (or longer if we run into any errors during dist build on main). I will do a final test after I address the comments above with a fresh fork. |
Oh I think I get what you meant, dont remove existing dist, let it autogenerate and commit instead. That would indeed work better, the reason I removed it here is because I was testing that the JIT build for int tests do work. I will re add them back. |
Yes this sounds good. Note to self, leave better comments. |
d58beb6
to
89ddb28
Compare
@averikitsch did another build release test here with current workflow https://github.com/bharathkkb/github-actions/actions/runs/298346191 |
No description provided.