Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support WIF creds #413

Merged
merged 4 commits into from
Dec 2, 2021
Merged

feat: Support WIF creds #413

merged 4 commits into from
Dec 2, 2021

Conversation

bharathkkb
Copy link
Contributor

fixes #396

@bharathkkb bharathkkb requested a review from a team as a code owner December 2, 2021 01:59
@google-cla google-cla bot added the cla: yes label Dec 2, 2021
sethvargo
sethvargo reviewed Dec 2, 2021
View reviewed changes
.github/workflows/setup-gcloud-it.yml Outdated Show resolved Hide resolved
.github/workflows/setup-gcloud-it.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/setup-gcloud.ts Outdated Show resolved Hide resolved
src/setup-gcloud.ts Outdated Show resolved Hide resolved
src/setup-gcloud.ts Show resolved Hide resolved
@bharathkkb bharathkkb mentioned this pull request Dec 2, 2021
Closed
@bharathkkb bharathkkb merged commit f38d54f into master Dec 2, 2021
@bharathkkb bharathkkb deleted the auth-wif branch December 2, 2021 17:38
@google-github-actions-bot google-github-actions-bot mentioned this pull request Dec 2, 2021
Merged
@steveoh
Copy link

steveoh commented Dec 2, 2021

Will you be sticking with the 0 based versioning with the next release?

@bharathkkb
Copy link
Contributor Author

@steveoh yes it will be 0.3.0 #338 for tracking. We will likely give the new features some soak time before cutting a 1.0.

@johnperez416 johnperez416 mentioned this pull request Apr 25, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch was automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workload federation credential file
3 participants
@bharathkkb @steveoh @sethvargo