Add infra for deploy-gke CI workflows #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One question I want to confirm with is that we do not essentially need to have the subnetwork set up as in https://github.com/google-github-actions/test-infra/blob/main/project_get-gke-credentials.tf#L108-L125 IIUC (since that is to mock client network use case through a private cluster?). |
sethvargo
reviewed
Apr 23, 2024
correct |
JeromeJu
force-pushed
the
deploy-gke-infra
branch
3 times, most recently
from
6a6acea
to
e02621c
Compare
This commit adds the infra variables for setting up the deploy-gke CI workflow inputs.
JeromeJu
force-pushed
the
deploy-gke-infra
branch
from
e02621c
to
56cbfad
Compare
sethvargo
approved these changes
Apr 30, 2024
Thanks for your time! That would be much appreciated. |
Merged
sethvargo
added a commit
that referenced
this pull request
May 1, 2024
Closes #65 Already applied --------- Co-authored-by: JeromeJu <jeromeju@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the infra variables for setting up the deploy-gke CI workflow inputs.