Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read and display vendor name and product name #137

Merged
merged 3 commits into from Jun 8, 2023
Merged

read and display vendor name and product name #137

merged 3 commits into from Jun 8, 2023

Conversation

edWin-m
Copy link
Contributor

@edWin-m edWin-m commented May 31, 2023

@pierredelisle This reads the VendorName and ProductName from the Basic Information Cluster. The attribute values are displayed alongside the respective IDs in the DeviceFragment. To some degree, it also resolves #35.

@pierredelisle
Copy link
Contributor

Sorry for the delay reviewing. Will get to it today.

@pierredelisle
Copy link
Contributor

Great work, thanks!
Only one thing, the changes to devices.proto will break backward compatibility. This is not a huge deal as this is just a demo application (and devs probably reset the app when installing a new version), but still, we like to show good practices. See https://protobuf.dev/programming-guides/proto3/#updating.

@edWin-m
Copy link
Contributor Author

edWin-m commented Jun 6, 2023

@pierredelisle Noted. 4d10a97 addresses the backward compatibility issue. Feel free to let me know if there is anything I might have missed.

pierredelisle
pierredelisle approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@pierredelisle pierredelisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks again.

@pierredelisle pierredelisle merged commit 2277ed4 into google-home:main Jun 8, 2023
2 checks passed
@edWin-m edWin-m deleted the feature-read-vendor-product-name branch June 9, 2023 01:18
@edWin-m
Copy link
Contributor Author

edWin-m commented Jun 9, 2023

Don't mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierredelisle pierredelisle pierredelisle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fields in Basic Info cluster
2 participants
@edWin-m @pierredelisle