Add Heatmap Example #19
Conversation
|
@barakplasma Hey! Thank you so much, It is looking good! Just be careful you added |
Project uses yarn
|
@itsmichaeldiego I deleted the package-lock.json . Do you want me to update the yarn.lock? |
src/index.js
Outdated
| @@ -28,6 +29,7 @@ ReactDOM.render( | |||
| <Route path={`${defaultPath}default`} component={Main} /> | |||
| <Route path={`${defaultPath}searchbox`} component={SearchBox} /> | |||
| <Route path={`${defaultPath}autocomplete`} component={Autocomplete} /> | |||
| <Route path={`${defaultPath}heatmap`} component={Heatmap} /> | |||
There was a problem hiding this comment.
not sure if I understood what you meant by align, so I sorted the import lines by length in d9ff68f
src/index.js
Outdated
| @@ -7,6 +7,7 @@ import Home from './Home'; | |||
| import Main from './examples/Main'; | |||
| import SearchBox from './examples/Searchbox'; | |||
| import Autocomplete from './examples/Autocomplete'; | |||
| import Heatmap from './examples/Heatmap'; | |||
There was a problem hiding this comment.
Can we align it like the rest? Sorry, OCD 😂
There was a problem hiding this comment.
not sure if I understood what you meant by align, so I sorted the import lines by length in d9ff68f
src/examples/Heatmap.js
Outdated
| <GoogleMap | ||
| defaultZoom={10} | ||
| defaultCenter={LOS_ANGELES_CENTER} | ||
| heatmapLibrary |
There was a problem hiding this comment.
Can we use instead:
bootstrapURLKeys={{
key: 'xxxxxxxxxxxxxx',
libraries: ['visualization'],
}}
There was a problem hiding this comment.
done in 8eab280
|
@barakplasma Hey man! First let me say this is looking great now, I just left two really minor comments and one where I want to hear what you think: #19 (comment) |
|
I'll correct the line breaks soon in order to pass CI |
|
@itsmichaeldiego sorry for the delay. I changed the line endings in order to pass eslint. This PR and google-map-react/google-map-react#716 (comment) seem ready to me for merge. |
|
Thanks @itsmichaeldiego ! I just want to remind you to run $ npm run deployfrom the master branch in order to deploy the Heatmap Example to the gh-pages site. Currently, the demo doesn't have the heatmap example. Alternatively, I can make another PR with that change for the gh-pages branch. |
|
@barakplasma Yeah I did not have time to publish, its published now! Let me know if it works for you |
|
@barakplasma BTW you might want to create a PR to add the example into the example list in README.md |
Screenshots:
This PR adds a heatmap example to the project.
Complements my PR to improve documentation for the feature: google-map-react/google-map-react#716