Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Bounds when surrounding div resizes #219

Merged
merged 9 commits into from Aug 22, 2016

Conversation

RUPOJS
Copy link
Contributor

@RUPOJS RUPOJS commented Aug 22, 2016

@istarkov
Copy link
Collaborator

Wow! Super!
I'll check it later today, but what I see now is really cool.

@istarkov
Copy link
Collaborator

istarkov commented Aug 22, 2016

Please add /* eslint-disable */ at the top of third-party libs, to pass through the travis checks

@RUPOJS
Copy link
Contributor Author

RUPOJS commented Aug 22, 2016

Thanks @istarkov .
I'll add that in next commit. Looking forward for your valuable feedback :)

onChildMouseEnter={onChildMouseEnter}
onChildMouseLeave={onChildMouseLeave}
resetBoundsOnResize={true}
apiKey={"AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you really want to share your API key with all world?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a dummy project with basic settings, so no harms in sharing it.

@@ -0,0 +1,51 @@
/* eslint-disable */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the last step is to delete this file?

@istarkov
Copy link
Collaborator

I found how to trigger internal gmap resize
please check that it will fix all issues

Please replace your _mapDomResizeCallback with this

  _mapDomResizeCallback = () => {
    this.resetSizeOnIdle_ = true;
    if (this.maps_) {
      this.maps_.event.trigger(this.map_, 'resize');
    }
  }

looks like it works perfectly for me

@RUPOJS
Copy link
Contributor Author

RUPOJS commented Aug 22, 2016

Hi @istarkov I did the suggested changes in the last commit :)

@istarkov istarkov merged commit e196e9f into google-map-react:master Aug 22, 2016
@istarkov
Copy link
Collaborator

Thank you!!!
Really good PR, and solve a real problem

@istarkov
Copy link
Collaborator

npm 0.18.0

@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants