Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump babel to version 6.14.0 - fixes class inheritance in IE <=10 #224

Merged
merged 1 commit into from Aug 25, 2016
Merged

Bump babel to version 6.14.0 - fixes class inheritance in IE <=10 #224

merged 1 commit into from Aug 25, 2016

Conversation

joaovpmamede
Copy link
Contributor

@joaovpmamede joaovpmamede commented Aug 25, 2016 •
edited

Fixes #223
Updated Babel packages to 6.14.0. More info here

@joaovpmamede joaovpmamede mentioned this pull request Aug 25, 2016
Closed
istarkov
istarkov reviewed Aug 25, 2016
View reviewed changes
.npmignore
@@ -1,6 +1,4 @@
src
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? imo current configuration is good enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm...sorry about this, I was testing something on my repo and by mistake I also pushed this.

@istarkov
Copy link
Collaborator

I'll merge this after you remove your changes to .npmignore
Sources are available on github, I see no reason to move them into npm

@joaovpmamede
Copy link
Contributor Author

Done and sorry for that.

@istarkov
Copy link
Collaborator

Thank you!!! Looks I forgot to made clean reinstall of node_modules last months, and this deps become a problem.

@istarkov istarkov merged commit e5ce93d into google-map-react:master Aug 25, 2016
@istarkov
Copy link
Collaborator

Will publish when npm install be completed.

@istarkov
Copy link
Collaborator

0.18.3, I wish you never wrote code for IE-9-10 again ;-)

@joaovpmamede
Copy link
Contributor Author

Hehe I wish that too...probably just in one or two years from now.

@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IE9 and IE10 - Unable to get property 'center' of undefined or null reference
2 participants
@joaovpmamede @istarkov