Add passive scroll

[jooj123]

Added passive scroll event (which is more performant).

See: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener (passive in options)

Needed the feature detection for browsers that dont support it

Note: hard to test this as the demos for google-map-react are all busted due to incorrect google maps key

[itsmichaeldiego]

@jooj123 Is this related to #625 ?

[jooj123]

@itsmichaeldiego this is the only place in this lib where it needs a passive event - so it should get rid of the warnings in the console and things should be a bit smoother (so yes its related to #625)

Come to think of it, i might as well add this to the other 4 event listeners too:

google-map-react/src/google_map.js

Line 248 in 6d142cb

window.addEventListener('resize', this._onWindowResize);

[itsmichaeldiego]

@jooj123 Sounds good, maybe we can create a new method call addPassiveEventListener so we avoid DRY, what do you think?

[jooj123]

@itsmichaeldiego updated. Not sure how i can unit test this as its browser specific functionality
I cant even validate it working correctly without the demo working incorrect due to google maps key

[itsmichaeldiego]

@jooj123 That is fine man! Thanks for this! Could you provide something like a video or whatever so I can see this is working? I really want to merge this but I've no time to test it :(

[itsmichaeldiego]

@jooj123 Bump!

[jooj123]

@itsmichaeldiego sorry havent had a chance to test this one - will do sometime over the weekend or next week

It would be much easier if the internal demo worked in this repo :(

[itsmichaeldiego]

@jooj123 What do you mean that the internal demo worked? We're working on new examples at https://github.com/google-map-react/google-map-react-examples

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.