New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue #235 #236
Fix Issue #235 #236
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@JlUgia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @dickermoshe.
I left a couple of comments for you to take a look.
We'll also need to merge the conflicts before submitting this. |
Rebased on |
Thank you @dickermoshe. |
Bug:
Fixes issue #235
The current implementation of the ApplePayButton only sets the payment items on create.
Changing the payment items after the button is created doesn't change the callback from onPressed.
Changes:
_UiKitApplePayButton
sets the callback on each build.Before:
Changing quantity didn't change the price
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-12-26.at.14.04.54.mp4
After:
Price changes due to quantity
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-12-26.at.14.03.55.mp4