Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pylint action with Google style configuration. #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucasb-eyer
Copy link
Collaborator

This would run pylint with the official Google style configuration on every PR automatically, saving us quite a bit of time.

We can already see results of it in this PR

However, it seems that maybe we should submit the configuration here and fine-tune it a bit? I'm seeing several lint errors that we don't actually hit internally, for example:
image
So we should see if we like this difference, and/or where it comes from, before merging.

Copy link
Collaborator

@andsteing andsteing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to

  1. reconfigure to exactly match issues that are also checked internally
  2. fix all complaints internally
  3. create PR from updated internal state
  4. merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants