-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federated Posterior Averaging (FedPA) #31
Federated Posterior Averaging (FedPA) #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: tests (which already exists internally) are to be modified added by rostami@ in follow-up CL.
09476d6
to
947de8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. I left some minor comments about naming conventions, but they're generally optional. Let me know when you think everything is in good shape, and I'll create the internal PR.
Thanks for the review, @zcharles8! I pushed a few changes. I think everything should be in good shape now. |
e144320
to
917e092
Compare
This PR adds the original implementation of FedPA in TFF.
I believe there's a similar internal CL (created in early Nov 2020) that wasn't merged into
google-research/federated
due to some build errors, which emerged because of fast-paced changes in TFF and this repository. In particular, FedPA heavily depends on theoptimization
subfolder which evolved over time. This PR has an up-to-date and fully working version compatible with theHEAD
of this repository and TFF nightly.