Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated Posterior Averaging (FedPA) #31

Merged
merged 7 commits into from
Apr 13, 2021

Conversation

alshedivat
Copy link
Contributor

This PR adds the original implementation of FedPA in TFF.

I believe there's a similar internal CL (created in early Nov 2020) that wasn't merged into google-research/federated due to some build errors, which emerged because of fast-paced changes in TFF and this repository. In particular, FedPA heavily depends on the optimization subfolder which evolved over time. This PR has an up-to-date and fully working version compatible with the HEAD of this repository and TFF nightly.

@google-cla google-cla bot added the cla: yes label Mar 30, 2021
Copy link

@rostamiz rostamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: tests (which already exists internally) are to be modified added by rostami@ in follow-up CL.

Copy link
Contributor

@zcharles8 zcharles8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I left some minor comments about naming conventions, but they're generally optional. Let me know when you think everything is in good shape, and I'll create the internal PR.

posterior_averaging/main/federated_trainer.py Outdated Show resolved Hide resolved
posterior_averaging/shared/fed_pa_schedule.py Outdated Show resolved Hide resolved
posterior_averaging/shared/fed_pa_schedule.py Outdated Show resolved Hide resolved
posterior_averaging/shared/fed_pa_schedule.py Outdated Show resolved Hide resolved
posterior_averaging/shared/fed_pa_schedule.py Outdated Show resolved Hide resolved
@alshedivat
Copy link
Contributor Author

Thanks for the review, @zcharles8! I pushed a few changes. I think everything should be in good shape now.

@nightldj nightldj merged commit 8822c76 into google-research:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants