Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding variable velocity to outputted MIDI notes #9

Closed
hturner08 opened this issue Apr 16, 2023 · 2 comments
Closed

Adding variable velocity to outputted MIDI notes #9

hturner08 opened this issue Apr 16, 2023 · 2 comments

Comments

@hturner08
Copy link

hturner08 commented Apr 16, 2023

My name is Herbie Turner and I'm an MIT CS Meng student working with my friend PhD student Ruben Castro, whose undergrad MechE thesis is cited in your paper. Together, we are working on a class project using your dataset and infrastructure. We're interested in including volume (velocity) in our reward function. Right now, we have some basic formulas for MIDI note velocity as a function of key angular velocity at the time of activation but I'm new to RL and using mujoco and am struggling to get the key angular velocity. I tried using qvel but it appears to be 0 for every timestep when running the example action sequence. Does anyone have suggestions?

@hturner08 hturner08 changed the title Adding velocity to state space Adding variable velocity to outputted MIDI notes Apr 16, 2023
@hturner08
Copy link
Author

Resolved, I added an observable that returns physics.bind(self._entity.joints).qvel

@kevinzakka
Copy link
Collaborator

Hi @hturner08, happy to hear you're working on this. Let me know if I can be of any assistance. It would be great to add velocity support to the benchmark. Let me know if we can work together on a PR once you finish your class project. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants