Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in tf_coder/datasets/github/data_loader.py(P2) #3

Closed
DLPerf opened this issue Aug 22, 2021 · 1 comment
Closed

Comments

@DLPerf
Copy link

DLPerf commented Aug 22, 2021

Hello,I found a performance issue in the definition of load_data ,
tf_coder/datasets/github/data_loader.py,
dataset = dataset.map(parse_example_proto) was called without num_parallel_calls.
I think it will increase the efficiency of your program if you add this.

Here is the documemtation of tensorflow to support this thing.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@kensens
Copy link
Collaborator

kensens commented Dec 23, 2021

Thank you for your comment, but the affected code is not used often, so this is low priority for us.

@kensens kensens closed this as completed Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants