-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit "Mask out private packages." broke library import #3
Comments
Hi, I just tried installing the library via ssh from master, and this doesn't appear to be a problem. Could you provide more context? As a side note, I understand that it could be confusing when different things have the same name. Though, the point I want to make is that Thanks, |
Hi,
If I simply do import torchsde, it fails with an error stating that there
is no _core module.
I will provide a colab replication tomorrow first thing in the morning if
that is not enough information.
Adrien
…On Tue, 4 Aug 2020, 20:54 Xuechen Li, ***@***.***> wrote:
Hi,
I just tried installing the library via ssh from master, and this doesn't
appear to be a problem. Could you provide more context?
Thanks,
Chen
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYGFZ6S3HBRGF5RO5KYZEDR7BDOBANCNFSM4PUQFYVA>
.
|
Does this error still occur when installing the master branch? Thanks. |
Can't say right now as I don't have access to a pc, but I did install from
master on colab using pip install git+etc.
…On Tue, 4 Aug 2020, 21:00 Xuechen Li, ***@***.***> wrote:
Does this error still occur when installing the master branch? Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYGFZ63X3QN7KABUO56AVLR7BEDTANCNFSM4PUQFYVA>
.
|
I just reproduced this on colab. I think it might have something to do with colab, since I'm not seeing this issue on my local machine or remote vm. I'll get this fixed ASAP. Thanks again for the report! For the time being, I'd recommend installing a previous version if the plan is just to play with the code, e.g. !pip install git+http://git@github.com/google-research/torchsde@v0.1.1 |
Just debugged this and found it to only be an issue for Python <= 3.6. Here's the related bug fix discussion https://bugs.python.org/issue30024 Will send in a commit soon to fix it so that it also works with Python>=3 <=3.6. |
See this comment:
41fb567#r41181450
The text was updated successfully, but these errors were encountered: