Bump dependencies #99
Conversation
|
Figured I'd see if it breaks anything! 😅 |
|
ping! Anyone able to take a look? At least kick off the CI? |
setup.py
Outdated
| @@ -34,7 +34,7 @@ | |||
| description="SDE solvers and stochastic adjoint sensitivity analysis in PyTorch.", | |||
| url="https://github.com/google-research/torchsde", | |||
| packages=setuptools.find_packages(exclude=['benchmarks', 'diagnostics', 'examples', 'tests']), | |||
| install_requires=['torch>=1.6.0', 'numpy==1.19.*', 'boltons>=20.2.1', 'trampoline>=0.1.2', 'scipy==1.5.*'], | |||
| install_requires=['torch>=1.6.0', 'numpy==1.20.*', 'boltons>=20.2.1', 'trampoline>=0.1.2', 'scipy==1.6.*'], | |||
There was a problem hiding this comment.
Could we change this to >=1.19.0 or something like that? Thanks.
There was a problem hiding this comment.
Also scipy==1.5.* => 'scipy>=1.5.*'?
There was a problem hiding this comment.
I was conservative with the changes as some maintainers prefer to pin to the minor version so as to avoid potential future breakage when a new release comes out. That of course, has to be weighed against the overhead of having to manually update the deps.
At least with conda pins can be applied retrospectively if a new version of a dependency breaks things so it's a bit safer to pin loosely.
|
The Py3.6 runs failed due to scipy not being compatible. I just replicated this behaviour on my machine as well. I think a simple workaround is to enforce the version more strictly using the Python version fetched during run time in Happy to also accept other potentially better sol'ns. Thanks for the patience again. |
|
@lxuechen One possible resolution -- I'd be happy to bump the minimum Python version to 3.7 if you are? I hear on the grapevine that that's the minimum version PyTorch is going to be supporting pretty soon anyway. |
That works for me. The latest |
For now, I think since torch hasn't dropped support for Python3.5, I'd prefer that we don't up the min version yet. Feel free to leave a TODO in |
|
Thanks again for sending in this PR, @dhirschfeld ! I still plan to merge this even though there's been a huge delay. If you could do a rebase from master and add the runtime Python version checks, I can merge this right away. Again, sorry for the unresponsiveness on my end. |
|
Hi @lxuechen, sorry I've been meaning to circle back to this but I'm pretty smashed with the end of the fin-year coming up. I might not get around to revisiting for a couple of weeks so I'm happy for you to take this over or to start fresh if you's like it in sooner - whatever is easiest. |
|
Hi @lxuechen . Is this PR ready to be merged? or are there some TODOs still remaining? |
|
Here is the PR https://github.com/Sayam753/torchsde/pull/1 at my fork which bumps the dependencies. I can roll out a PR in this repo if this is the right way to update dependencies :) |
|
The last Since |
|
@lxuechen / @patrick-kidger can you please approve the CI so that I can test out a solution using platform specific dependencies?
|
|
Approved the CI but I don't see any platform-specific dependencies in the current PR. |
Right, sorry - didn't push. Looks like it needs to be approved on every commit? That's not a great UX/DX for anyone! 😬 |
|
Same issue with |
No worries - looks like we got there in the end! 🎉 |
|
LGTM! Thanks for contributing, and resolving this issue. |
|
Thanks for the fast response and merging in the PR :) |
|
Just wanted to check if a release was imminent? If not I might patch the deps on the existing |
|
Installing from GitHub is the main option we support at the moment (we do need to put it on PyPI/conda already), so probably no imminent release. |
|
|
Resolves #98