Adjust windows so that method=resample
and method=rolling
align. Also set skipna=False
when computing statistics. This is anticipation of the following development workflow:
#143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust windows so that
method=resample
andmethod=rolling
align. Also setskipna=False
when computing statistics. This is anticipation of the following development workflow:Using
rolling
for ground truth is better thanresample
. If we usedresample
, then we'd have to be sure our forecast start times and timedeltas were aligned with the window used for ground truthClearly we could also roll the forecasts, but that barely increases statistical power and wastes time & space. For final WB evals, that may make sense, but for development we want something faster and more lightweight.