Fix compilation errors for QEMU mode for recent glibc #10
Conversation
See QEMU git commit 75e5b70e6b5dcc4f2219992d7cffa462aa406af0
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! It looks good to me. One question: would you be able to update https://github.com/google/AFL/blob/master/.travis.yml file so that it would also try building with QEMU support? That would be supper helpful.
Sure, I added the QEMU build to Travis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks a lot, @pietroferretti !
As explained in QEMU git commit 75e5b70e6b5dcc4f2219992d7cffa462aa406af0 (https://git.qemu.org/?p=qemu.git;a=commitdiff;h=75e5b70e6b5dcc4f2219992d7cffa462aa406af0), recent versions of the glibc add memfd_create, which creates conflicts at compile time for QEMU 2.10.
This can be fixed by adding a pair of patches when building QEMU with AFL support.