Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup guide with missing steps and more info #135

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Fix setup guide with missing steps and more info #135

merged 4 commits into from
Jul 1, 2021

Conversation

marcmerlin
Copy link
Contributor

  1. Add info for installing renode
  2. fix non working autolink for installing vivado
  3. add python virtualenv info
  4. add required nmigen
  5. better instructions on how to activate the code after make load

@marcmerlin
Fix setup guide with missing steps and more info
ecf96fd 
1) Add info for installing renode
2) fix non working autolink for installing vivado
3) add python virtualenv info
4) add required nmigen
5) better instructions on how to activate the code after make load
@marcmerlin marcmerlin mentioned this pull request Jun 23, 2021
Closed
@marcmerlin
Update setup-guide.rst
b4cd00b 
small formatting change
@marcmerlin
Update setup-guide.rst
7deeefd 
remove unnecessary pip install taken care of by scripts/setup
alanvgreen
alanvgreen approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@alanvgreen alanvgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy for this to go in as-is. Two nits, which I'll leave up to you as to whether to fix or not.

docs/source/setup-guide.rst Outdated Show resolved Hide resolved
@marcmerlin
Copy link
Contributor Author

Thanks for the review @alanvgreen , PTAL

@marcmerlin
Copy link
Contributor Author

@alanvgreen because of the perms, you'll need to re-approve and submit, I don't have perms :)

@marcmerlin marcmerlin requested review from google-admin and mithro and removed request for google-admin July 1, 2021 21:57
@marcmerlin
Copy link
Contributor Author

Hi @mithro , looks like the approve from @alanvgreen isn't enough to allow me to submit. Are you able to give me an approve that allows submit or submit for me ?

@mithro mithro merged commit daf222b into google:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcal-x tcal-x tcal-x left review comments

@alanvgreen alanvgreen alanvgreen approved these changes

@mithro mithro Awaiting requested review from mithro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcmerlin @alanvgreen @tcal-x @mithro