Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building verilated CFU for multiple sources #301

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

robertszczepanski
Copy link
Contributor

Fixes #293

Verilator will now treat project directory as an include directory and verilog source path is taken from $(CFU_VERILOG) variable. There was also a typo in this variable that created a path with additional space at the beginning ( /path/to/file instead of /path/to/file),

FYI @tcal-x

Signed-off-by: Robert Szczepanski <rszczepanski@antmicro.com>
@tcal-x
Copy link
Collaborator

tcal-x commented Sep 29, 2021

I retried make renode in proj/kws_micro_accel on this branch (fix-sv-build), after downloading the newest Renode. I see a lot of red timeout errors reported to the original terminal where I typed make renode, constantly scrolling:

22:50:13.0747 [ERROR] cpu.cfu0: CFU operation timeout, opcode: 0xd6878b, error: CfuTimeout
22:50:13.0767 [ERROR] cpu.cfu0: CFU operation timeout, opcode: 0x3e6160b, error: CfuTimeout (15)
22:50:13.0769 [ERROR] cpu.cfu0: CFU operation timeout, opcode: 0x2f6178b, error: CfuTimeout
22:50:13.0769 [ERROR] cpu.cfu0: CFU operation timeout, opcode: 0xb7a78b, error: CfuTimeout
22:50:13.0770 [ERROR] cpu.cfu0: CFU operation timeout, opcode: 0xb6c58b, error: CfuTimeout

Also, the model golden tests (1-1-g on the menu) don't pass.

Is that what you see, @robertszczepanski ? If you're seeing something different, then we need to figure out what's different in our setups.

@robertszczepanski
Copy link
Contributor Author

Hi @tcal-x I investigated this error and it turns out that there was a logic issue in Renode. I added a commit that bumps Renode to a version with a fix for that.
There is also tick synchronization of CPU and CFU turned off by default. It greatly improves simulation speed and you can easily turn it back on by adding frequency parameter to CFU constructor in .repl file.

I've tested these changes with mnv2_first, kws_micro_accel, hps_accel and example_cfu.

Remember to remove third_paty/renode and run scripts/setup to apply Renode update before testing this.

Signed-off-by: Robert Szczepanski <rszczepanski@antmicro.com>
@tcal-x
Copy link
Collaborator

tcal-x commented Oct 6, 2021

Thanks @robertszczepanski , I'll test it later today.

Copy link
Collaborator

@tcal-x tcal-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verilator-Renode simulation issue with proj/kws_micro_accel
2 participants