Skip to content

Commit

Permalink
Rename shouldUseDummySurface to shouldUsePlaceholderSurface
Browse files Browse the repository at this point in the history
This was likely missed in 33373d0.

PiperOrigin-RevId: 457422574
  • Loading branch information
tonihei authored and icbaker committed Jun 27, 2022
1 parent 20d2201 commit aaa0152
Showing 1 changed file with 4 additions and 4 deletions.
Expand Up @@ -626,7 +626,7 @@ private void setOutput(@Nullable Object output) throws ExoPlaybackException {
surface = placeholderSurface;
} else {
MediaCodecInfo codecInfo = getCodecInfo();
if (codecInfo != null && shouldUseDummySurface(codecInfo)) {
if (codecInfo != null && shouldUsePlaceholderSurface(codecInfo)) {
placeholderSurface = PlaceholderSurface.newInstanceV17(context, codecInfo.secure);
surface = placeholderSurface;
}
Expand Down Expand Up @@ -672,7 +672,7 @@ private void setOutput(@Nullable Object output) throws ExoPlaybackException {

@Override
protected boolean shouldInitCodec(MediaCodecInfo codecInfo) {
return surface != null || shouldUseDummySurface(codecInfo);
return surface != null || shouldUsePlaceholderSurface(codecInfo);
}

@Override
Expand Down Expand Up @@ -703,7 +703,7 @@ protected MediaCodecAdapter.Configuration getMediaCodecConfiguration(
deviceNeedsNoPostProcessWorkaround,
tunneling ? tunnelingAudioSessionId : C.AUDIO_SESSION_ID_UNSET);
if (surface == null) {
if (!shouldUseDummySurface(codecInfo)) {
if (!shouldUsePlaceholderSurface(codecInfo)) {
throw new IllegalStateException();
}
if (placeholderSurface == null) {
Expand Down Expand Up @@ -1330,7 +1330,7 @@ protected void renderOutputBufferV21(
maybeNotifyRenderedFirstFrame();
}

private boolean shouldUseDummySurface(MediaCodecInfo codecInfo) {
private boolean shouldUsePlaceholderSurface(MediaCodecInfo codecInfo) {
return Util.SDK_INT >= 23
&& !tunneling
&& !codecNeedsSetOutputSurfaceWorkaround(codecInfo.name)
Expand Down

0 comments on commit aaa0152

Please sign in to comment.