New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format.langauge for Arabic tracks return arb
instead of ar
#10255
Comments
ExoPlayer doesn't parse the For other macrolanguages, we have a special mapping list to detect individual languages and map them back to their standardized macrolanguage so that they are compatible (e.g. Indonesian, If you wonder why we haven't done that already and just map every existing individual code to its macrolanguage - the reason is simply that the list is too long and most of the codes are unlikely to ever appear in a media streaming service (see https://en.wikipedia.org/wiki/ISO_639_macrolanguage for a full list) |
Got it @tonihei answers my question. Thanks ✌️ |
This is an individual language (ISO 639-3) part of the Arabic macrolanguage ("ar" in ISO 639-1). Add this mapping to our existing list similar to other individual to macrolanguage mappings we have already. Issue: Issue: google/ExoPlayer#10255 PiperOrigin-RevId: 448911950
This is an individual language (ISO 639-3) part of the Arabic macrolanguage ("ar" in ISO 639-1). Add this mapping to our existing list similar to other individual to macrolanguage mappings we have already. Issue: Issue: #10255 PiperOrigin-RevId: 448911950
This is fixed by the commit above. |
Thank you ! |
When filing a question:
This is a sample manifest adaptation set that I am testing, for the English audio adaptation set I get the correct isoCode which is the 2 letters
en
I expected the same for the Arabic track as well, but it returned 3 letter iso codearb
.Is this expected for the Arabic language? is it IETF BCP 47 conformant or is it a bug?
I am using 2.16.1 as the exoplayer version.
cc @SaurabhOfficial @vinodkputta
The text was updated successfully, but these errors were encountered: