Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Tag EXT-X-DISCONTINUITY to insert a mid ad, not playing correctly. #6444

Closed
Romantic-LiXuefeng opened this issue Sep 19, 2019 · 3 comments
Assignees
Labels

Comments

@Romantic-LiXuefeng
Copy link

[REQUIRED] Issue description && Reproduction steps

Step1. Using the Shaka-Packager convert mp4 to HLS stream with ad cues at 60s.

$ packager 'in=/media/google_io_2017.mp4,stream=video,segment_template=/media/mp4_to_hls/h264_1080p/h264/$Number$.ts,playlist_name=/h264_1080p/h264.m3u8' \
      'in=/media/google_io_2017.mp4,stream=audio,segment_template=/media/mp4_to_hls/h264_1080p/aac/$Number$.aac,playlist_name=/h264_1080p/aac.m3u8' \
       --ad_cues 60 \
           --segment_duration 10 \
       --hls_master_playlist_output /media/mp4_to_hls/h264_master.m3u8

Step2: Because of the Shaka-Packager not supporting to mux audio and video into the same ts container. So I demux the ts format mid ad into separate auido ts and video ts.

Step3: Replace #EXT-X-PLACEMENT-OPPORTUNITY with EXT-X-DISCONTINUITY and Ad segment as described in https://github.com/google/shaka-packager/issues/650.

Can't play the mid ad. But if I disable the audio, only play the video, the playback is well.

The content I has sent to you to dev.exoplayer@gmail.com.

@Romantic-LiXuefeng
Copy link
Author

@Romantic-LiXuefeng
Copy link
Author

I have played the steam with Safari browser, the playback is well.

@AquilesCanta
Copy link
Contributor

A fix will be pushed soon, and a reference will appear in this thread. Thanks for reporting!

@AquilesCanta AquilesCanta self-assigned this Sep 20, 2019
tonihei pushed a commit that referenced this issue Sep 20, 2019
@google google deleted a comment from google-oss-bot Sep 20, 2019
@ojw28 ojw28 closed this as completed Sep 20, 2019
ojw28 pushed a commit that referenced this issue Sep 20, 2019
@google google locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants