Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to override the Shuffle and Repeat Drawables #6709

Closed
RowlandOti opened this issue Nov 29, 2019 · 3 comments
Closed

Unable to override the Shuffle and Repeat Drawables #6709

RowlandOti opened this issue Nov 29, 2019 · 3 comments
Assignees
Labels

Comments

@RowlandOti
Copy link

[REQUIRED] Issue description

This is an attempt to override the toggle on, off for both shufle and repeat drawables. It seems to not be working since I still see the default drawables for the two items above,.

[REQUIRED] Reproduction steps

Tried overriding the drawables using:
In styles.xml

</resources>
    <drawable name="exo_controls_shuffle">@drawable/ic_shuffle</drawable>
    <drawable name="exo_controls_shuffle_off">@drawable/ic_shuffle</drawable>
    <drawable name="exo_controls_shuffle_on">@drawable/ic_shuffle</drawable>
    <drawable name="exo_controls_repeat_off">@drawable/ic_repeat</drawable>
    <drawable name="exo_controls_repeat_one">@drawable/ic_repeat</drawable>
    <drawable name="exo_controls_repeat_all">@drawable/ic_repeat</drawable>
</resources>

[REQUIRED] Link to test content

N/A

[REQUIRED] A full bug report captured from the device

device-2019-11-29-110123

[REQUIRED] Version of ExoPlayer being used

vERSION IS 2.10.8

[REQUIRED] Device(s) and version(s) of Android being used

Android API 16 TO API 29

@ojw28
Copy link
Contributor

ojw28 commented Nov 29, 2019

Thanks for reporting this. We should add a layer of indirection to these drawables via drawables.xml, like we do for other icons, to make them easier to override.

@RowlandOti
Copy link
Author

Hoping this will make it in the next release, right?

marcbaechinger pushed a commit that referenced this issue Dec 4, 2019
This allows easy overriding of the resources by app developers

Issue: #6709
PiperOrigin-RevId: 283306121
@ojw28
Copy link
Contributor

ojw28 commented Dec 6, 2019

This will be included in 2.11

@ojw28 ojw28 closed this as completed Dec 6, 2019
ojw28 added a commit that referenced this issue Dec 6, 2019
This allows easy overriding of the resources by app developers

Issue: #6709
PiperOrigin-RevId: 283306121
@google google locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants