Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP3 XingSeeker with big audio size (~2 GB) #7337

Closed
simonvar opened this issue May 6, 2020 · 2 comments
Closed

MP3 XingSeeker with big audio size (~2 GB) #7337

simonvar opened this issue May 6, 2020 · 2 comments
Assignees
Labels

Comments

@simonvar
Copy link

simonvar commented May 6, 2020

Issue description

If try play mp3 with size ~2 GB, player throws exception -
java.lang.IllegalStateException: Top bit not zero: -2121515177.
It's happens in XingSeeker.create(...).
In this line long dataSize = frame.readUnsignedIntToInt();.
It's becuse readUnsignedIntToInt can return int in interval 0 .. 2,147,483,647, but size can be actual long. In my case 2,173,452,181 bytes.

Reproduction steps

  1. Play audio with size more than 2,147,483,647 bytes size.

Link to test content

You can use any mp3 file with size more than 2,147,483,647 bytes.
I sent on email my test case.

A full bug report captured from the device

I sent on email.

Version of ExoPlayer being used

2.11.4

Device(s) and version(s) of Android being used

Samsung SM-A505FN with Android 10.

@ojw28
Copy link
Contributor

ojw28 commented May 15, 2020

@Samrobbo - It would be good to get a fix in for this. It's probably just a case of using readUnsignedInt instead of readUnsignedIntToInt when reading dataSize.

@Samrobbo
Copy link
Contributor

@ojw28 @simonvar I'll look into this now. Thanks for the hint.

andrewlewis pushed a commit that referenced this issue May 18, 2020
@ojw28 ojw28 closed this as completed May 27, 2020
ojw28 pushed a commit that referenced this issue May 28, 2020
andrewlewis pushed a commit that referenced this issue Jun 1, 2020
@google google locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants