Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo app doesn't play ClearKey content on API level <= 26 #7735

Closed
TheJohnBowers opened this issue Aug 10, 2020 · 1 comment
Closed

Demo app doesn't play ClearKey content on API level <= 26 #7735

TheJohnBowers opened this issue Aug 10, 2020 · 1 comment
Assignees
Labels

Comments

@TheJohnBowers
Copy link
Contributor

TheJohnBowers commented Aug 10, 2020

[REQUIRED] Issue description

Exoplayer Demo application says clearkey is an unsupported DRM scheme on release-v2 branch (2.11.7). This only happens on actual devices, not on emulated devices.
I did not figure out exactly when it stopped working, I only know that it did work in 2.10.0 and it no longer works in 2.11.7

[REQUIRED] Reproduction steps

Simply try to play the test content below in the demo application on release-v2. The same content plays fine on 2.10.0
IMPORTANT - You must use a real device to see the issue. When using an emulated device content plays fine with 2.11.7

[REQUIRED] Link to test content

  {
    "name": "ClearKey sample that worked on 2.10.0",
    "uri": "https://content.uplynk.com/f3b6abb6da59413ab6f6241922a3b4e5.mpd?ck=1",
    "drm_scheme": "clearkey",
    "drm_license_url": "https://content.uplynk.com/ck",
    "drm_multi_session": true
  },

[REQUIRED] A full bug report captured from the device

Sent to dev.exoplayer@gmail.com as "Issue #7735"

[REQUIRED] Version of ExoPlayer being used

2.11.7

[REQUIRED] Device(s) and version(s) of Android being used

Android 7.0 Samsung Galaxy S8
Android Fire TV Stick
Those are the only 2 devices I have tested, but I suspect this issue is not really sensitive to devices or android versions.

@ojw28 ojw28 changed the title ClearKey content that played fine in exo 2.10 no longer plays on real devices with 2.11.7 Demo app doesn't play ClearKey content on API level <= 26 Aug 10, 2020
@ojw28
Copy link
Contributor

ojw28 commented Aug 10, 2020

It's not about whether it's running on an emulator or not. It's about the API level of the device. The issue occurs on API level 26 and earlier. The issue is only an issue with the demo app, not with the actual library. If you comment out the check that the demo app is making, playback works successfully on API level 26 and earlier.

The problem is that on API level 26 and earlier, the ClearKey CDM had to be accessed using C.COMMON_PSSH_UUID rather than C.CLEARKEY_UUID. The actual library code modifies the UUID to the one needed for playback, but the demo app is making a direct check for support without UUID modification. We'll fix that, or possibly just remove the check completely.

@ojw28 ojw28 self-assigned this Aug 10, 2020
kim-vde pushed a commit that referenced this issue Aug 17, 2020
Issue: Issue: #7735
PiperOrigin-RevId: 325900705
@ojw28 ojw28 closed this as completed Aug 18, 2020
ojw28 added a commit that referenced this issue Aug 19, 2020
Issue: Issue: #7735
PiperOrigin-RevId: 325900705
zxzx74147 pushed a commit to zxzx74147/ExoPlayer that referenced this issue Sep 7, 2020
Issue: Issue: google#7735
PiperOrigin-RevId: 325900705
@google google locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants