Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get key request type for renewal #7847

Closed
coshri opened this issue Sep 2, 2020 · 1 comment
Closed

get key request type for renewal #7847

coshri opened this issue Sep 2, 2020 · 1 comment
Assignees

Comments

@coshri
Copy link

coshri commented Sep 2, 2020

I'm using with Widevine DRM and I implement the MediaDrmCallback interface.
now I need to get information about the request type ( specific, if it is 'renewal' I need to add more information for server)

I see that android.media.MediaDrm.KeyRequest include getRequestType methods for this.

why ExoMediaDrm.KeyRequest doesn't contain this information?
there is another way (by ExoPlayer) to know if the request is for renewal?

Thanks a lot
Oshri

@ojw28
Copy link
Contributor

ojw28 commented Sep 3, 2020

I think the addition of getRequestType probably happened after we implemented ExoMediaDrm.KeyRequest, so this is just an omission. We can add it.

Note that getRequestType didn't exist in the platform until API level 23, and similarly, we'll only be able to make it work via ExoMediaDrm.KeyRequest from API level 23 onward. How do you plan to decide whether to attach your additional information on earlier API levels? Note that if you need to make this work, you may as well just do whatever you come up with for all API levels so as not to have to wait for us to add this functionality to the library. I also wonder whether you can't just attach the additional information in all cases, and have the server ignore it if it's not a renewal.

Marking as an enhancement to track adding something equivalent to getRequestType for API level 23 and above.

icbaker pushed a commit that referenced this issue Jan 15, 2021
Issue: #7847
PiperOrigin-RevId: 351661084
@icbaker icbaker closed this as completed Jan 15, 2021
@google google locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants