Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExoPlayer FFmpeg extension Build doc update #8581

Closed
Nodrex opened this issue Feb 12, 2021 · 3 comments
Closed

ExoPlayer FFmpeg extension Build doc update #8581

Nodrex opened this issue Feb 12, 2021 · 3 comments
Assignees
Labels

Comments

@Nodrex
Copy link

Nodrex commented Feb 12, 2021

In build doc (https://github.com/google/ExoPlayer/tree/release-v2/extensions/ffmpeg)
there is written that supported NDK is r20, as I know this version of NDk is deprecated, because there is r22 already.
So is this doc outdated and needs a refresh or we need to downgrade to deprecated r20 NDK to build FFmpeg extension ?

@kim-vde
Copy link
Contributor

kim-vde commented Feb 15, 2021

Thanks for reporting this.

Android NDK r20 is indeed deprecated. I tested the extensions with r22 and it seems to be working. I will update the documentation.

kim-vde added a commit that referenced this issue Feb 19, 2021
#minor-release
Issue:#8581
PiperOrigin-RevId: 357563419
@kim-vde kim-vde closed this as completed Feb 19, 2021
@Tolriq
Copy link
Contributor

Tolriq commented Feb 19, 2021

@kim-vde NDK 21 is the LTS version and should be used. NDK 22 have possible big size regressions and should be full tested against that.

@kim-vde kim-vde reopened this Feb 24, 2021
kim-vde added a commit that referenced this issue Feb 25, 2021
Latest LTS version is better than latest stable version because it will
be supported for longer.

#minor-release
Issue:#8581
PiperOrigin-RevId: 359467482
@kim-vde
Copy link
Contributor

kim-vde commented Feb 25, 2021

Yes, you are right. It is better to use the latest LTS version because it is supported for longer (I don't know about the regressions in r22). I updated the guidelines.

@kim-vde kim-vde closed this as completed Feb 25, 2021
marcbaechinger pushed a commit that referenced this issue Feb 25, 2021
Issue:#8581
PiperOrigin-RevId: 357563419
marcbaechinger pushed a commit that referenced this issue Feb 25, 2021
Latest LTS version is better than latest stable version because it will
be supported for longer.

#minor-release
Issue:#8581
PiperOrigin-RevId: 359467482
@google google locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants